Task 62649225378

refactor: Add [[nodiscard]] to functions returning bool+mutable ref

2026-02-05 16:58:13 completed 2602-nodiscard facb886a3a8b6fc1aa386f1139c2bbc381843159


Commands that took longer than 1 second (total 41m2s)
linedurationpercentagecommand
68733s1%retry pip3 install --user --break-system-packages pycapnp zmq
9531s0%cmake -S /Users/runner/work/bitcoin/bitcoin/repo_archive -B /Users/runner/work/bitcoin/bitcoin/repo_archive/ci/scratch/build-aarch64-apple-darwin24.6.0 -DBUILD_BENCH=ON -DBUILD_FUZZ_BINARY=ON -DWERROR=ON -DCMAKE_INSTALL_PREFIX=/Users/runner/work/bitcoin/bitcoin/repo_archive/ci/scratch/out -Werror=dev --preset=dev-mode -DWITH_USDT=OFF -DREDUCE_EXPORTS=ON '-DCMAKE_EXE_LINKER_FLAGS=-Wl,-stack_size -Wl,0x80000'
95727s1%- skipped
12901s0%compiler flags .................... -O2 -g -std=c++20 -fPIC -fmacro-prefix-map=/Users/runner/work/bitcoin/bitcoin/repo_archive/src=. -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -Wstack-protector -fstack-protector-all -mbranch-protection=bti -Werror -Wall -Wextra -Wgnu -Wformat -Wformat-security -Wvla -Wshadow-field -Wthread-safety -Wloop-analysis -Wredundant-decls -Wunused-member-function -Wdate-time -Wconditional-uninitialized -Woverloaded-virtual -Wsuggest-override -Wimplicit-fallthrough -Wunreachable-code -Wdocumentation -Wself-assign -Wundef -Wno-unused-parameter
130717m56s43%cmake --build /Users/runner/work/bitcoin/bitcoin/repo_archive/ci/scratch/build-aarch64-apple-darwin24.6.0 -j3 --target all install deploy
26271m2s2%ctest --test-dir /Users/runner/work/bitcoin/bitcoin/repo_archive/ci/scratch/build-aarch64-apple-darwin24.6.0 --stop-on-failure -j3 --timeout 2400
294616m37s40%/Users/runner/work/bitcoin/bitcoin/repo_archive/ci/scratch/build-aarch64-apple-darwin24.6.0/test/functional/test_runner.py -j3 --tmpdirprefix /Users/runner/work/bitcoin/bitcoin/repo_archive/ci/scratch/test_runner/ --ansi --combinedlogslen=99999999 --timeout-factor=40 --quiet --failfast
43204s0%'[' false = true ']'
Tags
  • macOS native
  • 2602-nodiscard
  • COMPLETED