Task 62021735678

Change BlockRequestAllowed() to take ref (minor refactor)

2026-01-30 16:57:22 completed block-req 8b6f6cba9ad25eb7a83a49011c4583202ef7dda8


Commands that took longer than 1 second (total 9m11s)
linedurationpercentagecommand
8210s0%dirname ./ci/test/00_setup_env.sh
8220s0%cd ./ci/test/../../
8230s0%pwd
8240s0%BASE_READ_ONLY_DIR=/home/admin/actions-runner/_work/bitcoin/bitcoin
8250s0%export BASE_READ_ONLY_DIR
8260s0%export BASE_ROOT_DIR=/home/admin/actions-runner/_work/_temp
8270s0%BASE_ROOT_DIR=/home/admin/actions-runner/_work/_temp
8280s0%export DEPENDS_DIR=/home/admin/actions-runner/_work/_temp/depends
8290s0%DEPENDS_DIR=/home/admin/actions-runner/_work/_temp/depends
8300s0%export BASE_SCRATCH_DIR=/home/admin/actions-runner/_work/_temp/ci/scratch
8310s0%BASE_SCRATCH_DIR=/home/admin/actions-runner/_work/_temp/ci/scratch
8320s0%echo 'Setting specific values in env'
8330s0%'[' -n ./ci/test/00_setup_env_native_tidy.sh ']'
8340s0%set -o errexit
8350s0%source ./ci/test/00_setup_env_native_tidy.sh
8360s0%export LC_ALL=C.UTF-8
8370s0%LC_ALL=C.UTF-8
8380s0%export CI_IMAGE_NAME_TAG=mirror.gcr.io/ubuntu:24.04
8390s0%CI_IMAGE_NAME_TAG=mirror.gcr.io/ubuntu:24.04
8400s0%export CONTAINER_NAME=ci_native_tidy
8410s0%CONTAINER_NAME=ci_native_tidy
8420s0%export TIDY_LLVM_V=21
8430s0%TIDY_LLVM_V=21
8440s0%export APT_LLVM_V=21
8450s0%APT_LLVM_V=21
8460s0%export 'PACKAGES=clang-21 libclang-21-dev llvm-21-dev libomp-21-dev clang-tidy-21 jq libevent-dev libboost-dev libzmq3-dev systemtap-sdt-dev qt6-base-dev qt6-tools-dev qt6-l10n-tools libqrencode-dev libsqlite3-dev libcapnp-dev capnproto'
8470s0%PACKAGES='clang-21 libclang-21-dev llvm-21-dev libomp-21-dev clang-tidy-21 jq libevent-dev libboost-dev libzmq3-dev systemtap-sdt-dev qt6-base-dev qt6-tools-dev qt6-l10n-tools libqrencode-dev libsqlite3-dev libcapnp-dev capnproto'
8480s0%export NO_DEPENDS=1
8490s0%NO_DEPENDS=1
8500s0%export RUN_UNIT_TESTS=false
8510s0%RUN_UNIT_TESTS=false
8520s0%export RUN_FUNCTIONAL_TESTS=false
8530s0%RUN_FUNCTIONAL_TESTS=false
8540s0%export RUN_FUZZ_TESTS=false
8550s0%RUN_FUZZ_TESTS=false
8570s0%export RUN_CHECK_DEPS=true
8580s0%RUN_CHECK_DEPS=true
8590s0%export RUN_TIDY=true
8600s0%RUN_TIDY=true
8610s0%export GOAL=install
8620s0%GOAL=install
8630s0%export 'BITCOIN_CONFIG= --preset dev-mode -DCMAKE_C_COMPILER=clang-21 -DCMAKE_CXX_COMPILER=clang++-21 -DCMAKE_C_FLAGS_RELWITHDEBINFO='\''-O0 -g0'\'' -DCMAKE_CXX_FLAGS_RELWITHDEBINFO='\''-O0 -g0'\'' '
8640s0%BITCOIN_CONFIG=' --preset dev-mode -DCMAKE_C_COMPILER=clang-21 -DCMAKE_CXX_COMPILER=clang++-21 -DCMAKE_C_FLAGS_RELWITHDEBINFO='\''-O0 -g0'\'' -DCMAKE_CXX_FLAGS_RELWITHDEBINFO='\''-O0 -g0'\'' '
8650s0%echo 'Fallback to default values in env (if not yet set)'
8660s0%command -v nproc
8670s0%nproc
8690s0%export MAKEJOBS=-j8
8700s0%MAKEJOBS=-j8
8710s0%export RUN_UNIT_TESTS=false
8720s0%RUN_UNIT_TESTS=false
8730s0%export RUN_FUNCTIONAL_TESTS=false
8740s0%RUN_FUNCTIONAL_TESTS=false
8750s0%export RUN_TIDY=true
8760s0%RUN_TIDY=true
8770s0%export TEST_RUNNER_TIMEOUT_FACTOR=40
8780s0%TEST_RUNNER_TIMEOUT_FACTOR=40
8790s0%export RUN_FUZZ_TESTS=false
8800s0%RUN_FUZZ_TESTS=false
8810s0%export BOOST_TEST_RANDOM=1
8820s0%BOOST_TEST_RANDOM=1
8830s0%export DEBIAN_FRONTEND=noninteractive
8840s0%DEBIAN_FRONTEND=noninteractive
8850s0%export CCACHE_MAXSIZE=500M
8860s0%CCACHE_MAXSIZE=500M
8870s0%export CCACHE_TEMPDIR=/tmp/.ccache-temp
8880s0%CCACHE_TEMPDIR=/tmp/.ccache-temp
8890s0%export CCACHE_COMPRESS=1
8900s0%CCACHE_COMPRESS=1
8910s0%export CCACHE_DIR=/home/admin/actions-runner/_work/_temp/ccache_dir
8920s0%CCACHE_DIR=/home/admin/actions-runner/_work/_temp/ccache_dir
8930s0%export BASE_OUTDIR=/home/admin/actions-runner/_work/_temp/ci/scratch/out
8940s0%BASE_OUTDIR=/home/admin/actions-runner/_work/_temp/ci/scratch/out
8950s0%export PREVIOUS_RELEASES_DIR=/home/admin/actions-runner/_work/_temp/previous_releases
8960s0%PREVIOUS_RELEASES_DIR=/home/admin/actions-runner/_work/_temp/previous_releases
8970s0%export 'CI_BASE_PACKAGES=build-essential pkgconf curl ca-certificates ccache python3-dev rsync git procps bison e2fsprogs cmake ninja-build'
8980s0%CI_BASE_PACKAGES='build-essential pkgconf curl ca-certificates ccache python3-dev rsync git procps bison e2fsprogs cmake ninja-build'
8990s0%export GOAL=install
9000s0%GOAL=install
9010s0%export DIR_QA_ASSETS=/home/admin/actions-runner/_work/_temp/ci/scratch/qa-assets
9020s0%DIR_QA_ASSETS=/home/admin/actions-runner/_work/_temp/ci/scratch/qa-assets
9030s0%export CI_RETRY_EXE=retry
9040s0%CI_RETRY_EXE=retry
9050s0%export CI_IMAGE_PLATFORM=linux
9060s0%CI_IMAGE_PLATFORM=linux
9070s0%set -o errexit
9080s0%./ci/test/02_run_container.py
9100s0%bash -c 'grep export ./ci/test/00_setup_env*.sh'
9110s0%cat /tmp/env-admin-ci_native_tidy
94739s7%docker buildx build --file=/home/admin/actions-runner/_work/bitcoin/bitcoin/ci/test_imagefile --build-arg=CI_IMAGE_NAME_TAG=mirror.gcr.io/ubuntu:24.04 --build-arg=FILE_ENV=./ci/test/00_setup_env_native_tidy.sh --build-arg=BASE_ROOT_DIR=/home/admin/actions-runner/_work/_temp --platform=linux --label=bitcoin-ci-test --tag=ci_native_tidy --cache-from type=gha,url=http://127.0.0.1:12321/,url_v2=http://127.0.0.1:12321/,scope=ci_native_tidy --load /home/admin/actions-runner/_work/bitcoin/bitcoin
10280s0%docker volume create ci_native_tidy_ccache
10300s0%docker volume create ci_native_tidy_depends
10320s0%docker volume create ci_native_tidy_depends_sources
10340s0%docker volume create ci_native_tidy_previous_releases
10360s0%docker network create --ipv6 --subnet 1111:1111::/112 ci-ip6net
10390s0%docker image prune --force --filter label=bitcoin-ci-test
10411s0%docker run --rm --interactive --detach --tty --cap-add=LINUX_IMMUTABLE --mount=type=bind,src=/home/admin/actions-runner/_work/bitcoin/bitcoin,dst=/home/admin/actions-runner/_work/bitcoin/bitcoin,readonly --mount=type=bind,src=/home/admin/actions-runner/_work/_temp/ccache_dir,dst=/home/admin/actions-runner/_work/_temp/ccache_dir --mount=type=bind,src=/home/admin/actions-runner/_work/_temp/depends/built,dst=/home/admin/actions-runner/_work/_temp/depends/built --mount=type=bind,src=/home/admin/actions-runner/_work/_temp/depends/sources,dst=/home/admin/actions-runner/_work/_temp/depends/sources --mount=type=bind,src=/home/admin/actions-runner/_work/_temp/previous_releases,dst=/home/admin/actions-runner/_work/_temp/previous_releases --mount=type=bind,src=/home/admin/actions-runner/_work/_temp/build,dst=/home/admin/actions-runner/_work/_temp/build --env-file=/tmp/env-admin-ci_native_tidy --name=ci_native_tidy --network=ci-ip6net --platform=linux ci_native_tidy
10420s0%docker exec 4b9e101d8ce6d62b874e05a0e0526ef2dbeb901a0b99d2c238fdba56bd935f45 rsync --recursive --perms --stats --human-readable /home/admin/actions-runner/_work/bitcoin/bitcoin/ /home/admin/actions-runner/_work/_temp
10600s0%docker exec 4b9e101d8ce6d62b874e05a0e0526ef2dbeb901a0b99d2c238fdba56bd935f45 /home/admin/actions-runner/_work/_temp/ci/test/01_base_install.sh
10610s0%CFG_DONE=/home/admin/actions-runner/_work/_temp/ci.base-install-done
10620s0%cat /home/admin/actions-runner/_work/_temp/ci.base-install-done
10630s0%'[' done == done ']'
10640s0%echo 'Skip base install'
10650s0%exit 0
10670s0%docker exec 4b9e101d8ce6d62b874e05a0e0526ef2dbeb901a0b99d2c238fdba56bd935f45 /home/admin/actions-runner/_work/_temp/ci/test/03_test_script.sh
10680s0%cd /home/admin/actions-runner/_work/_temp
10690s0%export 'PATH=/path_with space:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin'
10700s0%PATH='/path_with space:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin'
10710s0%export ASAN_OPTIONS=detect_leaks=1:detect_stack_use_after_return=1:check_initialization_order=1:strict_init_order=1
10720s0%ASAN_OPTIONS=detect_leaks=1:detect_stack_use_after_return=1:check_initialization_order=1:strict_init_order=1
10730s0%export LSAN_OPTIONS=suppressions=/home/admin/actions-runner/_work/_temp/test/sanitizer_suppressions/lsan
10740s0%LSAN_OPTIONS=suppressions=/home/admin/actions-runner/_work/_temp/test/sanitizer_suppressions/lsan
10750s0%export TSAN_OPTIONS=suppressions=/home/admin/actions-runner/_work/_temp/test/sanitizer_suppressions/tsan:halt_on_error=1:second_deadlock_stack=1
10760s0%TSAN_OPTIONS=suppressions=/home/admin/actions-runner/_work/_temp/test/sanitizer_suppressions/tsan:halt_on_error=1:second_deadlock_stack=1
10770s0%export UBSAN_OPTIONS=suppressions=/home/admin/actions-runner/_work/_temp/test/sanitizer_suppressions/ubsan:print_stacktrace=1:halt_on_error=1:report_error_type=1
10780s0%UBSAN_OPTIONS=suppressions=/home/admin/actions-runner/_work/_temp/test/sanitizer_suppressions/ubsan:print_stacktrace=1:halt_on_error=1:report_error_type=1
10790s0%nproc
10800s0%echo 'Number of available processing units: 8'
10810s0%'[' '' == macos ']'
10820s0%free -m -h
10870s0%uname --kernel-name --kernel-release
10880s0%echo 'System info: Linux 6.14.0-37-generic'
10890s0%lscpu
11060s0%echo 'Free disk space:'
11070s0%df -h
11450s0%[[ ci_native_tidy == \c\i\_\n\a\t\i\v\e\_\a\s\a\n ]]
11460s0%/home/admin/actions-runner/_work/_temp/depends/config.guess
11470s0%export HOST=x86_64-pc-linux-gnu
11480s0%HOST=x86_64-pc-linux-gnu
11490s0%echo '=== BEGIN env ==='
11500s0%env
11570s0%echo '=== END env ==='
11580s0%[[ '' != true ]]
12020s0%tee /dev/fd/63
12030s0%patch -p1
12040s0%'[' false = true ']'
12050s0%'[' false = true ']'
12060s0%'[' '' == macos ']'
12070s0%echo
12090s0%b/src/leveldb/db/db_impl.cc
12190s0%1].Add(stats);
12210s0%'[' -z 1 ']'
12220s0%'[' '' = true ']'
12230s0%BITCOIN_CONFIG_ALL='-DBUILD_BENCH=ON -DBUILD_FUZZ_BINARY=ON'
12240s0%'[' -z 1 ']'
12250s0%'[' -z '' ']'
12260s0%BITCOIN_CONFIG_ALL='-DBUILD_BENCH=ON -DBUILD_FUZZ_BINARY=ON -DWERROR=ON'
12270s0%ccache --zero-stats
12290s0%PRINT_CCACHE_STATISTICS='ccache --version | head -n 1 && ccache --show-stats'
12300s0%BASE_BUILD_DIR=/home/admin/actions-runner/_work/_temp/build
12310s0%BITCOIN_CONFIG_ALL='-DBUILD_BENCH=ON -DBUILD_FUZZ_BINARY=ON -DWERROR=ON -DCMAKE_INSTALL_PREFIX=/home/admin/actions-runner/_work/_temp/ci/scratch/out -Werror=dev'
12320s0%[[ '' == true ]]
12330s0%[[ true == true ]]
12340s0%BITCOIN_CONFIG_ALL='-DBUILD_BENCH=ON -DBUILD_FUZZ_BINARY=ON -DWERROR=ON -DCMAKE_INSTALL_PREFIX=/home/admin/actions-runner/_work/_temp/ci/scratch/out -Werror=dev -DCMAKE_EXPORT_COMPILE_COMMANDS=ON'
12350s0%eval 'CMAKE_ARGS=(-DBUILD_BENCH=ON -DBUILD_FUZZ_BINARY=ON -DWERROR=ON -DCMAKE_INSTALL_PREFIX=/home/admin/actions-runner/_work/_temp/ci/scratch/out -Werror=dev -DCMAKE_EXPORT_COMPILE_COMMANDS=ON --preset dev-mode -DCMAKE_C_COMPILER=clang-21 -DCMAKE_CXX_COMPILER=clang++-21 -DCMAKE_C_FLAGS_RELWITHDEBINFO='\''-O0 -g0'\'' -DCMAKE_CXX_FLAGS_RELWITHDEBINFO='\''-O0 -g0'\'' )'
12360s0%CMAKE_ARGS=(-DBUILD_BENCH=ON -DBUILD_FUZZ_BINARY=ON -DWERROR=ON -DCMAKE_INSTALL_PREFIX=/home/admin/actions-runner/_work/_temp/ci/scratch/out -Werror=dev -DCMAKE_EXPORT_COMPILE_COMMANDS=ON --preset dev-mode -DCMAKE_C_COMPILER=clang-21 -DCMAKE_CXX_COMPILER=clang++-21 -DCMAKE_C_FLAGS_RELWITHDEBINFO='-O0 -g0' -DCMAKE_CXX_FLAGS_RELWITHDEBINFO='-O0 -g0')
123711s1%cmake -S /home/admin/actions-runner/_work/_temp -B /home/admin/actions-runner/_work/_temp/build -DBUILD_BENCH=ON -DBUILD_FUZZ_BINARY=ON -DWERROR=ON -DCMAKE_INSTALL_PREFIX=/home/admin/actions-runner/_work/_temp/ci/scratch/out -Werror=dev -DCMAKE_EXPORT_COMPILE_COMMANDS=ON --preset dev-mode -DCMAKE_C_COMPILER=clang-21 -DCMAKE_CXX_COMPILER=clang++-21 '-DCMAKE_C_FLAGS_RELWITHDEBINFO=-O0 -g0' '-DCMAKE_CXX_FLAGS_RELWITHDEBINFO=-O0 -g0'
15750s0%compiler .......................... Clang 21.1.8, /usr/bin/clang++-21
15780s0%compiler flags .................... -O0 -g0 -std=c++20 -fPIC -fmacro-prefix-map=/home/admin/actions-runner/_work/_temp/src=. -Wstack-protector -fstack-protector-all -fcf-protection=full -fstack-clash-protection -Werror -Wall -Wextra -Wgnu -Wformat -Wformat-security -Wvla -Wshadow-field -Wthread-safety -Wthread-safety-pointer -Wloop-analysis -Wredundant-decls -Wunused-member-function -Wdate-time -Wconditional-uninitialized -Woverloaded-virtual -Wsuggest-override -Wimplicit-fallthrough -Wunreachable-code -Wdocumentation -Wself-assign -Wundef -Wno-unused-parameter
15920s0%[[ install != all ]]
15930s0%[[ install != codegen ]]
15940s0%GOAL='all install'
159514s2%cmake --build /home/admin/actions-runner/_work/_temp/build -j8 --target all install
27830s0%bash -c 'ccache --version | head -n 1 && ccache --show-stats'
27950s0%ccache --show-stats
27960s0%grep Hits:
27970s0%head -1
27980s0%sed 's/.*(\(.*\)%).*/\1/'
27990s0%hit_rate=99.54
28000s0%'[' 99 -lt 75 ']'
28010s0%du -sh /home/admin/actions-runner/_work/_temp/depends/SDKs/ /home/admin/actions-runner/_work/_temp/depends/builders/ /home/admin/actions-runner/_work/_temp/depends/built/ /home/admin/actions-runner/_work/_temp/depends/hosts/ /home/admin/actions-runner/_work/_temp/depends/packages/ /home/admin/actions-runner/_work/_temp/depends/patches/ /home/admin/actions-runner/_work/_temp/depends/sdk-sources/ /home/admin/actions-runner/_work/_temp/depends/sources/
28100s0%du -sh /home/admin/actions-runner/_work/_temp/previous_releases
28120s0%'[' -n '' ']'
28130s0%'[' -n '' ']'
28140s0%'[' true = true ']'
28152s0%/home/admin/actions-runner/_work/_temp/contrib/devtools/check-deps.sh /home/admin/actions-runner/_work/_temp/build
28320s0%'[' false = true ']'
28330s0%'[' false = true ']'
28340s0%'[' true = true ']'
28350s0%cmake -B /tidy-build -DLLVM_DIR=/usr/lib/llvm-21/cmake -DCMAKE_BUILD_TYPE=Release -S /home/admin/actions-runner/_work/_temp/contrib/devtools/bitcoin-tidy
28390s0%- skipped
28475s0%cmake --build /tidy-build -j8
28520s0%cmake --build /tidy-build --target bitcoin-tidy-tests -j8
28590s0%set -eo pipefail
28600s0%jq 'map(select(.file | test("src/qt/.*_autogen/.*\\.cpp$") | not))' /home/admin/actions-runner/_work/_temp/build/compile_commands.json
28610s0%mv tmp.json /home/admin/actions-runner/_work/_temp/build/compile_commands.json
28620s0%cd /home/admin/actions-runner/_work/_temp/build/src/
28630s0%run-clang-tidy-21 -quiet -load=/tidy-build/libbitcoin-tidy.so -j8
28647m18s79%tee tmp.tidy-out.txt
50870s0%[[ '' == true ]]
50880s0%'[' false = true ']'
50906s1%docker container kill 4b9e101d8ce6d62b874e05a0e0526ef2dbeb901a0b99d2c238fdba56bd935f45
Tags
  • tidy
  • block-req
  • COMPLETED