Task 105628777297

refactor: Change some validation.cpp methods to return BlockValidationState

2026-09-18 14:04:42 completed 2605-validation-state-return 1de8a2e4a1f9787ec9b2f3ee8d07ad9b1b3181a3

build_duration:8m35s
ccache_hitrate:54s
configure_duration:2s
unit_test_duration:50s

Commands that took longer than 1 second (total 31m35s)

line	duration	percentage	command
744	2s	0%	`retry pip3 install --user --break-system-packages pycapnp pyzmq`
973	1s	0%	`retry curl --location --fail https://github.com/bitcoin-core/qa-assets/raw/main/unit_test_data/script_assets_test.json -o '/Users/runner/work/bitcoin/bitcoin/repo_archive/ci/scratch_ ₿🧪_/qa-assets/unit_test_data//script_assets_test.json'`
996	2s	0%	`cmake -S /Users/runner/work/bitcoin/bitcoin/repo_archive -B '/Users/runner/work/bitcoin/bitcoin/repo_archive/ci/scratch_ ₿🧪_/build-aarch64-apple-darwin24.6.0' -DCMAKE_COMPILE_WARNING_AS_ERROR=ON -DBUILD_BENCH=ON -DBUILD_FUZZ_BINARY=ON '-DCMAKE_INSTALL_PREFIX=/Users/runner/work/bitcoin/bitcoin/repo_archive/ci/scratch_ ₿🧪_/out' -Werror=dev --preset=dev-mode -DWITH_USDT=OFF -DREDUCE_EXPORTS=ON '-DCMAKE_EXE_LINKER_FLAGS=-Wl,-stack_size -Wl,0x80000'`
1001	1s	0%	`- skipped`
1016	18s	0%	`features - done`
1355	8m35s	27%	`cmake --build '/Users/runner/work/bitcoin/bitcoin/repo_archive/ci/scratch_ ₿🧪_/build-aarch64-apple-darwin24.6.0' -j3 --target all install deploy`
3053	50s	2%	`ctest --test-dir '/Users/runner/work/bitcoin/bitcoin/repo_archive/ci/scratch_ ₿🧪_/build-aarch64-apple-darwin24.6.0' --stop-on-failure -j3 --timeout 2400`
3826	20m26s	64%	`'/Users/runner/work/bitcoin/bitcoin/repo_archive/ci/scratch_ ₿🧪_/build-aarch64-apple-darwin24.6.0/test/functional/test_runner.py' -j3 --tmpdirprefix '/Users/runner/work/bitcoin/bitcoin/repo_archive/ci/scratch_ ₿🧪_/test_runner/' --ansi --combinedlogslen=99999999 --timeout-factor=40 --quiet --failfast`
5314	3s	0%	`'[' false = true ']'`

Tags

2605-validation-state-return