Task 105628777295

refactor: Change some validation.cpp methods to return BlockValidationState

2026-09-18 14:04:42 completed 2605-validation-state-return 1de8a2e4a1f9787ec9b2f3ee8d07ad9b1b3181a3


Commands that took longer than 1 second (total 22m23s)
linedurationpercentagecommand
114835s2%docker buildx build --file=/home/runner/work/bitcoin/bitcoin/ci/test_imagefile --build-arg=CI_IMAGE_NAME_TAG=mirror.gcr.io/ubuntu:26.04 --build-arg=FILE_ENV=./ci/test/00_setup_env_native_iwyu.sh --build-arg=BASE_ROOT_DIR=/home/runner/work/_temp --platform=linux --label=bitcoin-ci-test --tag=ci_native_iwyu --cache-from type=gha,url=http://127.0.0.1:49160/,version=1,scope=ci_native_iwyu --load /home/runner/work/bitcoin/bitcoin
354211s0%features - done
38632s0%cmake --build '/home/runner/work/_temp/build_ ₿🧪_' -j8 --target codegen bitcoin_node_raw_data_headers mp_headers mptest_headers bitcoin_ipc_headers bitcoin_ipc_test_headers bitcoin_ipc_fuzz_headers
40355m17s23%python3 /include-what-you-use/iwyu_tool.py -p '/home/runner/work/_temp/build_ ₿🧪_' -j8 -- -Xiwyu --cxx17ns -Xiwyu --mapping_file=/home/runner/work/_temp/contrib/devtools/iwyu/bitcoin.core.imp -Xiwyu '--mapping_file=/home/runner/work/_temp/build_ ₿🧪_/clang.intrinsics.imp' -Xiwyu --max_line_length=160 -Xiwyu '--check_also=*/common/types\.h' -Xiwyu '--check_also=*/consensus/*\.h' -Xiwyu '--check_also=*/interfaces/*\.h' -Xiwyu '--check_also=*/primitives/transaction_identifier\.h' -Xiwyu '--check_also=*/rpc/protocol\.h'
66222m48s12%python3 /include-what-you-use/iwyu_tool.py -p '/home/runner/work/_temp/build_ ₿🧪_' -j8 -- -Xiwyu --cxx17ns -Xiwyu --mapping_file=/home/runner/work/_temp/contrib/devtools/iwyu/bitcoin.core.imp -Xiwyu '--mapping_file=/home/runner/work/_temp/build_ ₿🧪_/clang.intrinsics.imp' -Xiwyu --max_line_length=160 -Xiwyu '--check_also=*/common/types\.h' -Xiwyu '--check_also=*/consensus/*\.h' -Xiwyu '--check_also=*/interfaces/*\.h' -Xiwyu '--check_also=*/primitives/transaction_identifier\.h' -Xiwyu '--check_also=*/rpc/protocol\.h'
1354344s3%should remove these lines:
1476812m8s54%should remove these lines:
389461s0%python3 /include-what-you-use/fix_includes.py --nosafe_headers
396467s0%./contrib/devtools/clang-format-diff.py -binary=clang-format-23 -p1 -i -v
594396s0%docker container kill a683b562412d1f19ec8baa1174bbe5fc39036ca84ee2876b4a3029079f6b068b
Tags
  • iwyu
  • 2605-validation-state-return
  • COMPLETED