Task 103182390566

refactor: Change some validation.cpp methods to return BlockValidationState

2026-09-11 07:22:06 completed 2605-validation-state-return 981912489d89d40a2f54b58b9e035906e5cb4737


Commands that took longer than 1 second (total 20m31s)
linedurationpercentagecommand
111036s2%docker buildx build --file=/home/runner/work/bitcoin/bitcoin/ci/test_imagefile --build-arg=CI_IMAGE_NAME_TAG=mirror.gcr.io/ubuntu:26.04 --build-arg=FILE_ENV=./ci/test/00_setup_env_native_iwyu.sh --build-arg=BASE_ROOT_DIR=/home/runner/work/_temp --platform=linux --label=bitcoin-ci-test --tag=ci_native_iwyu --cache-from type=gha,url=http://127.0.0.1:49160/,version=1,scope=ci_native_iwyu --load /home/runner/work/bitcoin/bitcoin
349010s0%features - done
38101s0%cmake --build '/home/runner/work/_temp/build_ ₿🧪_' -j8 --target codegen mp_headers mptest_headers bitcoin_ipc_headers bitcoin_ipc_test_headers bitcoin_ipc_fuzz_headers
39803m57s19%python3 /include-what-you-use/iwyu_tool.py -p '/home/runner/work/_temp/build_ ₿🧪_' -j8 -- -Xiwyu --cxx17ns -Xiwyu --mapping_file=/home/runner/work/_temp/contrib/devtools/iwyu/bitcoin.core.imp -Xiwyu '--mapping_file=/home/runner/work/_temp/build_ ₿🧪_/clang.intrinsics.imp' -Xiwyu --max_line_length=160 -Xiwyu '--check_also=*/common/types\.h' -Xiwyu '--check_also=*/consensus/*\.h' -Xiwyu '--check_also=*/interfaces/*\.h' -Xiwyu '--check_also=*/primitives/transaction_identifier\.h' -Xiwyu '--check_also=*/rpc/protocol\.h'
65172m40s12%python3 /include-what-you-use/iwyu_tool.py -p '/home/runner/work/_temp/build_ ₿🧪_' -j8 -- -Xiwyu --cxx17ns -Xiwyu --mapping_file=/home/runner/work/_temp/contrib/devtools/iwyu/bitcoin.core.imp -Xiwyu '--mapping_file=/home/runner/work/_temp/build_ ₿🧪_/clang.intrinsics.imp' -Xiwyu --max_line_length=160 -Xiwyu '--check_also=*/common/types\.h' -Xiwyu '--check_also=*/consensus/*\.h' -Xiwyu '--check_also=*/interfaces/*\.h' -Xiwyu '--check_also=*/primitives/transaction_identifier\.h' -Xiwyu '--check_also=*/rpc/protocol\.h'
1343543s3%should remove these lines:
1465411m46s57%should remove these lines:
385681s0%python3 /include-what-you-use/fix_includes.py --nosafe_headers
392638s0%./contrib/devtools/clang-format-diff.py -binary=clang-format-23 -p1 -i -v
588647s0%docker container kill 207d952d55d1c07a61a8e16fbe7b1abd37a8f7a2013827304ed0d427d7cfc296
Tags
  • iwyu
  • 2605-validation-state-return
  • COMPLETED